Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to WinUI 2.7 #976

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update to WinUI 2.7 #976

wants to merge 7 commits into from

Conversation

BobbyESP
Copy link

@BobbyESP BobbyESP commented Oct 30, 2021

App style update

PR Type

What kind of change does this PR introduce?

  • Updated most of the components of the app to WinUI 2.7

Bugs known

  • Settings NavigationView doesn't load the first NavigationItem

Captura de pantalla 2021-10-30 182615

  • Some strange errors when opening the app in App.xaml.cs file, line 50 related with AppCenter (never heard about that)

dependabot bot and others added 5 commits October 30, 2021 18:08
nuget-deps: bump Microsoft.AppCenter.Crashes in /src/Notepads (0x7c13#959)

Bumps Microsoft.AppCenter.Crashes from 4.1.0 to 4.4.0.

---
updated-dependencies:
- dependency-name: Microsoft.AppCenter.Crashes
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jiaqi Liu <[email protected]>
@BobbyESP
Copy link
Author

The errors in App.xaml.cs:
Captura de pantalla 2021-10-30 183705
Captura de pantalla 2021-10-30 183749
Captura de pantalla 2021-10-30 183730

@BobbyESP
Copy link
Author

Ah yes, forgot to tell that the Navigation Item that doesn't open when you open settings can be opened by clicking on it. Just fails when you open the settings.

@BobbyESP BobbyESP changed the title Update to Windows 11 style, WinUI 3.0 Update to WinUI 2.7 Oct 30, 2021
@0x7c13
Copy link
Owner

0x7c13 commented Oct 31, 2021

I will be working on the visual update by EOY. I will wait for WinUI 2.x to get mature before doing so.

@BobbyESP
Copy link
Author

It's ok. If you need some help, tell me. WinUI 3 by the moment isn't avaliable for UWP or it's very unestable, so better wait.

@0x5bfa
Copy link

0x5bfa commented Dec 25, 2021

Delete all custom style and update UI:
image

@0x5bfa
Copy link

0x5bfa commented Mar 5, 2022

@BobbyESP Hai. how have you seen:)

Settings NavigationView doesn't load the first NavigationItem

FYI, It's a not bug but specification. so, need to load the page in NaviView_Loaded() or Page_Loaded()

Instead, use the IsSelected flag to receive change events on ItemSelected. but this app uses ItemInvoked() this do not trigger selection changing event from IsSelected = true.

https://github.com/JasonStein/Notepads/blob/master/src/Notepads/Views/Settings/SettingsPage.xaml#L18

@BobbyESP
Copy link
Author

BobbyESP commented Mar 5, 2022

Ohh, i see!

@0x7c13
Copy link
Owner

0x7c13 commented Mar 14, 2022

I am waiting for WinUI v2.8 stable release before looking into upgrading the UX. Are there any issues you find with v2.8 prerelease?

@0x5bfa
Copy link

0x5bfa commented Mar 15, 2022

ah. I don't have the problem I saw in WinUI prerelease in UI Control, but I found a lot in WerbView2 regardless of whether you are using WebView2.

Also, due to that issue, projects that download WinUI 2.8 prerelease may fail in store submissions.
In fact, I came across that error of win cert kit.

It may be a big help, why not use WinUI2.7 stable ver?

@0x5bfa
Copy link

0x5bfa commented Mar 15, 2022

And when updating to WinUI 2.7 or later, the IsSelect property does not trigger the ItemInvoked event. It still triggers SelectionChanged, so you need to navigate to the initial page when loading the settings page. You will find it during the migration.

@0x7c13
Copy link
Owner

0x7c13 commented Mar 15, 2022

There are some other UI issues bringing by the v2.7 release, I cannot remmeber the exact but it has been disscussed earlier. The rolling speed of the WinUI 2 and 3 releases are much slower than my expectation:(

@KParthSingh
Copy link

Guys It has been over two years now. When will this UI update take place?

@KParthSingh
Copy link

@0x5bfa
Copy link

0x5bfa commented Feb 20, 2024

The owner hesitates to move to WinUI2.8 or 3.0 because it would bring more WinUI-side issues.

@KParthSingh
Copy link

Damn.

@emvaized
Copy link

emvaized commented Mar 19, 2024

WinUI-side issues

Are these issues are still relevant as for today? WinUI v2.8 stable release came out quite a long time ago.

@0x5bfa
Copy link

0x5bfa commented Mar 19, 2024

I said the same thing to them. lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants