⛳ gas optimizing the font file. #11
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on gas optimizing the
silkscreenfont.Strategy
silkscreenuse the same glyphs, we can get rid of uppercase characters.fand delete the other metadata.MirakaiScrollsRenderer.solhas been changed to use the new font name in thesvg'sstylesection. The new font name isf. AlsoSCROLL #Xon line403has been changed toscroll #X(Note that both would render uppercase glyphs).A new test file
test/MirakaiSaveFile.t.solhas also been added to compare gas consumption by thesaveFileofsrc/MirakaiScrollsRenderer.sol. This test file uses a newforgecheat codereadFile. So to run this test,forgeneeds to be updated. Here are the results:This result shows that we can save a quite a lot of gas for the initialization of the
MirakaiScrollsRenderer.solPS: The code formatting for the
src/MirakaiScrollsRenderer.solwas removed by someone else's commit. The formatting is reintroduced again.