Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've been updating my server and realized that the most recent few versions of mailcatcher have been failing the build. I don't really know golang so this is just me messing around but I got the build green and it works in my quick tests.
Comments for each commit:
gcc
was causing the issue for the builds:I didn't really figure out why but
build-base
works and only makes thebuilder
docker image slightly larger.smtp-debug-server
, working up through each major version: https://github.com/emersion/go-smtp/blob/v0.19.0/cmd/smtp-debug-server/main.go.I'm not that experienced with github actions but to test the build I had to remove the
push
ing part from the workflow. You can see here that each commit has a happy green build.Happy Holidays!
Jonah