fix(cli): hide secret env values in --help output#83
Merged
Conversation
clap prints the current value of an arg's `env` var in --help by default, which leaks secrets (e.g. `[env: WEBCLAW_API_KEY=wc_...]`) for anyone who has them set. Add `hide_env_values = true` to every arg backed by a credential-bearing env var so --help shows the variable name only. Covers the CLI (WEBCLAW_API_KEY, SERPER_API_KEY, WEBCLAW_PROXY, WEBCLAW_PROXY_FILE, WEBCLAW_WEBHOOK_URL, WEBCLAW_LLM_BASE_URL) and the server (WEBCLAW_API_KEY). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
clap renders the current value of an arg's
envvar in--helpby default. For anyone who has the secret set in their environment,webclaw --helpprints it in the clear:Fix
Add
hide_env_values = trueto every arg backed by a credential-bearing env var.--helpnow shows the variable name only:Covered args:
webclaw-cli):WEBCLAW_API_KEY,SERPER_API_KEY,WEBCLAW_PROXY,WEBCLAW_PROXY_FILE,WEBCLAW_WEBHOOK_URL,WEBCLAW_LLM_BASE_URLwebclaw-server):WEBCLAW_API_KEYVerified
cargo build -p webclaw-cli -p webclaw-server).cargo fmt --checkpasses.--helpwith dummy secret env values set: variable names show, values do not;0occurrences of the dummy value in help output.🤖 Generated with Claude Code