Skip to content

chore: update toolchain to nightly-2026-04-29#1098

Merged
bitwalker merged 2 commits intonextfrom
bitwalker/nightly-2026-04-29
May 1, 2026
Merged

chore: update toolchain to nightly-2026-04-29#1098
bitwalker merged 2 commits intonextfrom
bitwalker/nightly-2026-04-29

Conversation

@bitwalker
Copy link
Copy Markdown
Collaborator

Updates our Rust toolchain to 1.97/nightly-2026-04-29, and updates all of our dependencies as much as possible (though there are still a couple cases where we keep an older version) - I also didn't update any of the wit-bindgen-related deps.

I'm hoping this might make #1090 a little cleaner now that Rust has removed --allow-undefined from its default wasm-ld flags, but we'll see.

@bitwalker bitwalker requested a review from greenhat May 1, 2026 03:54
@bitwalker
Copy link
Copy Markdown
Collaborator Author

bitwalker commented May 1, 2026

@greenhat I think we should remove the cargo-miden integration tests (specifically the ones that generate the integration workspace from the project-template repo) from this repo, and move them to the project-template repo (which already does in fact run the same tests AIUI). Those two tests fail every time there is some kind of weird divergence between nightlies (e.g. in this case, an older version of hashbrown was specializing on Copy and that isn't supported now, so it fails to compile). Since those tests aren't actually running the right version of cargo-miden anyway (because the version the generated integration workspace uses is pulled from crates.io), there is basically no point in running them in our CI.

@greenhat
Copy link
Copy Markdown
Contributor

greenhat commented May 1, 2026

@greenhat I think we should remove the cargo-miden integration tests (specifically the ones that generate the integration workspace from the project-template repo) from this repo, and move them to the project-template repo (which already does in fact run the same tests AIUI). Those two tests fail every time there is some kind of weird divergence between nightlies (e.g. in this case, an older version of hashbrown was specializing on Copy and that isn't supported now, so it fails to compile). Since those tests aren't actually running the right version of cargo-miden anyway (because the version the generated integration workspace uses is pulled from crates.io), there is basically no point in running them in our CI.

I agree. Make them ignored and I'll take care of moving them to the project-template repo.

@bitwalker bitwalker force-pushed the bitwalker/nightly-2026-04-29 branch from 7b21c26 to f05f654 Compare May 1, 2026 13:17
@bitwalker bitwalker merged commit 62e3d0c into next May 1, 2026
16 checks passed
@bitwalker bitwalker deleted the bitwalker/nightly-2026-04-29 branch May 1, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants