updated StorageMapAccess::get return Option<V>#676
Open
PoulavBhowmick03 wants to merge 1 commit into0xMiden:nextfrom
Open
updated StorageMapAccess::get return Option<V>#676PoulavBhowmick03 wants to merge 1 commit into0xMiden:nextfrom
StorageMapAccess::get return Option<V>#676PoulavBhowmick03 wants to merge 1 commit into0xMiden:nextfrom
Conversation
PoulavBhowmick03
changed the title
StorageMapAccess::get return Option<V>
greenhat
requested changes
Sep 15, 2025
Contributor
greenhat
left a comment
greenhat
left a comment
There was a problem hiding this comment.
Thank you! Please check my comment.
| fn get(&self, key: &K) -> V { | ||
| storage::get_map_item(self.slot, key.as_ref()).into() | ||
| fn get(&self, key: &K) -> Option<V> { | ||
| Some(storage::get_map_item(self.slot, key.as_ref()).into()) |
Contributor
There was a problem hiding this comment.
The idea was to test if get_map_item returns zero word and if so - return None. See the Why section in #673.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #673