Conversation
|
* docs: add module and function documentations * Update miden-crypto/src/merkle/smt/mod.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update miden-crypto/src/merkle/smt/full/error.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Update miden-crypto/src/merkle/smt/full/error.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * LeafIndex * Update miden-crypto/src/merkle/smt/full/error.rs Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com> * Remove * LeafIndex to mod * Priv * Update mod.rs * CHANGELOG.md --------- Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
* fix doctest for `MerkleStore` Commit b83b134 (#411) migrated uses of RpoDigest to Word, but missed the return value of the helper function `int_to_node()` in the doctest for `merkle::store::MerkleStore`. This wasn't caught by CI as CI does not currently run doctests -- something that will be fixed in the next commit. * CI: run doctests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+48
to
+59
| doc-tests: | ||
| name: doc-tests | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.event_name == 'pull_request' && (github.base_ref == 'main' || github.base_ref == 'next') }} | ||
| strategy: | ||
| fail-fast: false | ||
| steps: | ||
| - uses: actions/checkout@main | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - name: Run doc-tests | ||
| run: | | ||
| rustup update --no-self-update |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 11 months ago
To fix the issue, we will add a permissions block at the root level of the workflow to apply to all jobs. Since the workflow only performs testing and documentation tasks, it likely only requires contents: read permissions. This ensures that the workflow has the minimal permissions necessary to function while reducing the risk of unintended actions.
Suggested changeset
1
.github/workflows/test.yml
| @@ -3,2 +3,4 @@ | ||
| name: test | ||
| permissions: | ||
| contents: read | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
* chore: bump winterfell up and update licence * add PR id * add files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tracking PR for v0.15.0 release.