Skip to content

Tracking PR for v0.17.0#489

Merged
bobbinth merged 22 commits intomainfrom
next
Sep 12, 2025
Merged

Tracking PR for v0.17.0#489
bobbinth merged 22 commits intomainfrom
next

Conversation

@bobbinth
Copy link
Copy Markdown
Contributor

This is a tracking PR for v0.17.0 release.

bobbinth and others added 16 commits August 15, 2025 23:57
…ization (#502)

* Remove redundant length checks after read_array in SecretKey deserialization

* fix fmt
* feat: add benchmark infrastructure and common utilities

- Add benchmark common module w/ configuration constants
- Add data generation utilities for consistent test data
- macro system for reducing boilerplate
- parameterized benchmarks with throughput measurement

* feat: implement comprehensive benchmarking infrastructure

- Add benchmarking infrastructure with common utilities and macros
- Port all existing benchmarks to use new macro system for consistency
- Add support for multiple benchmark categories (hash, dsa, word, rand)

* chore: clippy

* chore: changelog

* review comments

- Aligned all benchmark file section headers to use `// === Section Name ===` format
- Updated `smt-with-entries.rs` to use the standardized format

- Fixed ambiguous doc notation in `common/mod.rs`
- Removed confusion around size specification in function names

- Eliminated empty hash-to-point benchmarks section from `dsa.rs`
- Updated criterion groups to exclude removed benchmarks

- Changed all hash benchmarks to use consistent `generate_byte_array_sequential()`

- Simplified integer casting in `hash_rpo256_merge_with_int` and `hash_rpx256_merge_with_int`
- Added explanatory comments clarifying the intent

- Corrected benchmarks that incorrectly called `merge` instead of `merge_many`

- Added `benchmark_rand_comprehensive!` macro to eliminate repetitive random coin benchmark code
- Added `benchmark_word_conversions!` macro to consolidate type conversion benchmarks

- Consolidated 5 separate type conversion benchmarks into 1 macro-based benchmark
- Updated criterion groups to reflect new consolidated benchmark names

* Benchmark README reorg
* chore: reuse shared lint workflows

* chore: add make targets for linting

* chore: format toml files

* chore: fix typos

* chore: run clippy in stable

* chore: enable workspace lints checks

* fix: missing newline after comment!

* chore: add installation makefile targets

* fix: machete should ignore getrandom
@bobbinth bobbinth marked this pull request as ready for review September 12, 2025 23:18
@bobbinth bobbinth merged commit 6525652 into main Sep 12, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants