Conversation
cargo-fuzz requires the Rust nightly compiler because it uses unstable
compiler flags like -Zsanitizer=address for memory sanitization during
fuzzing. Without nightly, the build fails with:
error: the option `Z` is only accepted on the nightly compiler
Add dtolnay/rust-toolchain@nightly step to both fuzz jobs before
running cargo-fuzz.
Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com>
MSRV verification now runs on push to main/next (dry-run) and on GitHub release publish (actual crates.io publish).
As lineages are kept separate within the forest, it is possible to have two distinct trees with the same content and hence the same root. As we were previously identifying trees using the root alone, this could potentially lead to accidental data modification or returning the wrong information from queries. This commit updates the forest to instead identify trees using a `Root`, which is a pair of a user-provided domain identifier, and the root value itself. This avoids the ambiguity entirely.
These were requested to help the new implementation serve the existing use-case. This commit also fixes a minor lint in one of the tests for the existing forest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tracking PR for v0.22.0 release.