chore: backport LargeSmtForest to 0.19.x branch#834
Merged
drahnr merged 3 commits intoversion/0.19.xfrom Feb 18, 2026
Merged
Conversation
0c81380 to
70ac3d1
Compare
c1f46b0 to
a8f9efc
Compare
iamrecursion
approved these changes
Feb 18, 2026
Collaborator
iamrecursion
left a comment
There was a problem hiding this comment.
Insofar as this looks like the code I wrote and the fix for truncate is in place, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
LargeSmtfromnexttoversion/0.19.xbranch and a few minimal adjacent non-breaking changes, which are limited tomod test_utilsaddition and a minor extension toSmtLeaf:Why do we want this backported?
node PR 0xMiden/miden-node#1635 introduces a free-style version of the
LargeForestSmtwith inMemorybackend, using this implementation should lead to easier to maintain code and do away with a lot of (hopefully all) helper lookup tables.