chore: continue with miden-base update (0904e2c61)#1815
Open
juan518munoz wants to merge 2 commits intoandrew-migrate-to-next-basefrom
Open
chore: continue with miden-base update (0904e2c61)#1815juan518munoz wants to merge 2 commits intoandrew-migrate-to-next-basefrom
juan518munoz wants to merge 2 commits intoandrew-migrate-to-next-basefrom
Conversation
juan518munoz
changed the title
juan518munoz
added
the
no changelog
juan518munoz
force-pushed
the
jmunoz-migrate-to-next-base
branch
from
a58d2f5 to
bd0859a
Compare
juan518munoz
force-pushed
the
jmunoz-migrate-to-next-base
branch
from
0d25a9a to
6c10836
Compare
juan518munoz
commented
Feb 26, 2026
| /// Represents a `proto::rpc::SyncStateResponse` with fields converted into domain types. | ||
| /// Represents the composed result of `sync_notes`, `sync_chain_mmr`, and `sync_transactions` | ||
| /// with fields converted into domain types. | ||
| pub struct StateSyncInfo { |
Collaborator
Author
There was a problem hiding this comment.
Maybe we should move this elsewhere as it's no longer part of the domain
Collaborator
There was a problem hiding this comment.
Agree, maybe into crates/rust-client/src/sync/state_sync.rs since it's only used there.
juan518munoz
requested review from
Fumuran,
JereSalo,
SantiagoPittella,
TomasArrachea and
igamigo
Comment on lines
+57
to
+59
| # inputs are passed as foreign_procedure_inputs: | ||
| # [slot_id_prefix, slot_id_suffix, KEY, pad(10)] | ||
| exec.active_account::get_map_item |
Collaborator
There was a problem hiding this comment.
Should we still push the storage slot here? Why was this changed to assumed inputs?
|
|
||
| ### Changes | ||
|
|
||
| * [BREAKING] Incremented MSRV to 1.91. |
Collaborator
There was a problem hiding this comment.
Lets add the API changes for the rpc trait
Comment on lines
+57
to
+70
| struct StatusService; | ||
|
|
||
| #[async_trait::async_trait] | ||
| impl worker_status_api_server::WorkerStatusApi for StatusService { | ||
| async fn status( | ||
| &self, | ||
| _: tonic::Request<()>, | ||
| ) -> Result<tonic::Response<proto::WorkerStatus>, tonic::Status> { | ||
| Ok(tonic::Response::new(proto::WorkerStatus { | ||
| version: env!("CARGO_PKG_VERSION").to_string(), | ||
| supported_proof_type: proto::ProofType::Transaction as i32, | ||
| })) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Do we need to implement this? Maybe we can remove the status service if we don't use it.
Comment on lines
+89
to
+96
| pub fn with_supports_all_types(self) -> Self { | ||
| let metadata = self.0.metadata().clone().with_supports_all_types(); | ||
| let code = self.0.component_code().clone(); | ||
| let slots = self.0.storage_slots().to_vec(); | ||
| AccountComponent( | ||
| NativeAccountComponent::new(code, slots, metadata) | ||
| .expect("reconstructing component with updated metadata should not fail"), | ||
| ) |
Collaborator
There was a problem hiding this comment.
This method was removed from the AccountComponent struct so maybe we should remove it here as well, instead of working around it.
Comment on lines
+545
to
+547
| /// highest `block_num`. This replicates the old `SyncState` behavior where the node returned | ||
| /// the latest account commitment per account in the synced range. | ||
| fn derive_account_commitment_updates( |
Collaborator
There was a problem hiding this comment.
Maybe rename this to something like derive_latest_commitments()? Also, I'd rather not reference the "old" implementation in the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue with node & base update to update the
miden-basedependency to commit0904e2c61.Note:
or expose the previously used structs again.