-
Notifications
You must be signed in to change notification settings - Fork 95
feat: rocksdb storage for AccountTree and NullifierTree by default
#1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
6daa5cf
essential
drahnr 388cf70
CI
drahnr d99fef7
Apply suggestion from @Mirko-von-Leipzig
drahnr e4d11eb
disable account reconstruction more systematically
drahnr 132915b
lost and found
drahnr 087cb7b
yay
drahnr 089de41
sanity, please
drahnr 9faa663
cleanup
drahnr d8a5dc2
simplify
drahnr 3ca9a5b
gating
drahnr 5362e21
fixup
drahnr cf6c342
fixin
drahnr 90ec80b
rocksdb system libs too old, debian; populate if rocksdb is empty
drahnr 90c122f
fix
drahnr a29ed14
fix
drahnr f2be23c
review
drahnr d868965
more
drahnr d2e5a52
taplo
drahnr b8fa48f
yesyes, booleans
drahnr 35976f3
fix
drahnr 58fd77b
10m is not enough
drahnr 9715a0c
Merge remote-tracking branch 'origin/next' into bernhard-1227-add-opt…
drahnr 46461a8
proper runners for heavy duty tasks
drahnr 6357928
accidentally readded, removed in 50680fe
drahnr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: "Install RocksDB dependencies" | ||
| description: "Install dependencies for RocksDB compilation" | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Install LLVM/Clang for RocksDB | ||
| shell: bash | ||
| run: | | ||
| set -eux | ||
| sudo apt-get update | ||
| # Install clang/llvm for bindgen (needed for FFI bindings). | ||
| # RocksDB is compiled from source by librocksdb-sys. | ||
| sudo apt-get install -y clang llvm-dev libclang-dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not loving the CI complexity.
Is the goal not to always have this enabled? When would we run a node without this once its working? I would imagine that CI caching should keep the compile times in check or no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really hate the CI crap that's part of the PR.
The CI caching should keep the CI times in check, but right now
rocksdbalso compiles it's C/CXX dependency, which takes a while.The rationale: It takes a while to compile rocksdb. If it's cached, it re-claims a good chunk of cache size. I don't necessarily want to cache this at all. I'd preferably link statically against host libraries (at least in CI), but this has proven itself to be fragile (llvm compiler version fun).
I am very open to suggestions how to handle this.
Also: Not a fan of GHA, it's a constrained dumpsterfire.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simplified it to use host libraries. As said earlier, no good solutions, only trade-offs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Host libraries are too old on debian 🫠