feat: rocksdb storage for AccountTree and NullifierTree by default

.github/actions/install-rocksdb/action.yml

@@ -0,0 +1,14 @@
+name: "Install RocksDB"
+description: "Install dependencies for RocksDB compilation"
+
+runs:
+  using: "composite"
+  steps:
+    - name: Install LLVM/Clang for RocksDB
+      shell: bash
+      run: |
+        set -eux
+        sudo apt-get update
+        # Install clang/llvm for bindgen (needed for FFI bindings).
+        # RocksDB is compiled from source by librocksdb-sys.
+        sudo apt-get install -y clang llvm-dev libclang-dev

.github/workflows/lint.yml

@@ -51,6 +51,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@main
+      - name: Cleanup large tools for build space
+        uses: ./.github/actions/cleanup-runner
+      - name: Install RocksDB
+        uses: ./.github/actions/install-rocksdb
       - name: Rustup
         run: |
           rustup update --no-self-update
@@ -87,6 +91,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@main
+      - name: Cleanup large tools for build space
+        uses: ./.github/actions/cleanup-runner
+      - name: Install RocksDB
+        uses: ./.github/actions/install-rocksdb
       - name: Rustup
         run: rustup update --no-self-update
       - uses: Swatinem/rust-cache@v2

.github/workflows/msrv.yml

@@ -0,0 +1,39 @@
+name: Check MSRV
+
+on:
+  push:
+    branches: [next]
+  pull_request:
+    types: [opened, reopened, synchronize]
+
+# Limits workflow concurrency to only the latest commit in the PR.
+concurrency:
+  group: "${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}"
+  cancel-in-progress: true
+
+permissions:
+  contents: read
+
+env:
+  # Reduce cache usage by removing debug information.
+  CARGO_PROFILE_DEV_DEBUG: 0
+
+jobs:
+  # Check MSRV (aka `rust-version`) in `Cargo.toml` is valid for workspace members
+  msrv:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install RocksDB
+        uses: ./.github/actions/install-rocksdb
+      - name: Install dependencies
+        run: sudo apt-get update && sudo apt-get install -y jq
+      - uses: dtolnay/rust-toolchain@stable
+      - uses: Swatinem/rust-cache@v2
+        with:
+          save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/next' }}
+      - name: Install cargo-msrv
+        run: cargo install cargo-msrv
+      - name: Check MSRV for each workspace member
+        run: |
+          ./scripts/check-msrv.sh

.github/workflows/publish-debian-all.yml

@@ -31,6 +31,8 @@ jobs:
         uses: actions/checkout@main
         with:
           fetch-depth: 0
+      - name: Install RocksDB
+        uses: ./.github/actions/install-rocksdb
       - name: Build and Publish Node
         uses: ./.github/actions/debian
         with:

.github/workflows/publish-debian.yml

@@ -60,6 +60,9 @@ jobs:
         with:
           fetch-depth: 0
 
+      - name: Install RocksDB
+        uses: ./.github/actions/install-rocksdb
+
       - name: Build and Publish Packages
         uses: ./.github/actions/debian
         with:

.github/workflows/publish-dry-run.yml

@@ -23,6 +23,8 @@ jobs:
           fetch-depth: 0
       - name: Cleanup large tools for build space
         uses: ./.github/actions/cleanup-runner
+      - name: Install RocksDB
+        uses: ./.github/actions/install-rocksdb
       - name: Install dependencies
         run: sudo apt-get update && sudo apt-get install -y jq
       - name: Update Rust toolchain

.github/workflows/publish-main.yml

@@ -18,6 +18,8 @@ jobs:
         with:
           fetch-depth: 0
           ref: main
+      - name: Install RocksDB
+        uses: ./.github/actions/install-rocksdb
       # Ensure the release tag refers to the latest commit on main.
       # Compare the commit SHA that triggered the workflow with the HEAD of the branch we just
       # checked out (main).

.github/workflows/stress-test-check.yml

@@ -27,6 +27,8 @@ jobs:
     timeout-minutes: 10
     steps:
       - uses: actions/checkout@main
+      - name: Install RocksDB
+        uses: ./.github/actions/install-rocksdb
       - name: Rustup
         run: rustup update --no-self-update
       - uses: Swatinem/rust-cache@v2

.github/workflows/test-beta.yml

@@ -16,6 +16,8 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: 'next'
+      - name: Install RocksDB
+        uses: ./.github/actions/install-rocksdb
       - name: Rustup
         run: rustup install beta && rustup default beta
       - uses: taiki-e/install-action@nextest 

.github/workflows/test.yml

@@ -28,6 +28,10 @@ jobs:
     timeout-minutes: 30
     steps:
       - uses: actions/checkout@main
+      - name: Cleanup large tools for build space
+        uses: ./.github/actions/cleanup-runner
+      - name: Install RocksDB
+        uses: ./.github/actions/install-rocksdb
       - name: Rustup
         run: rustup update --no-self-update
       - uses: Swatinem/rust-cache@v2

CHANGELOG.md

@@ -112,6 +112,7 @@
 - Add optional `TransactionInputs` field to `SubmitProvenTransaction` endpoint for transaction re-execution (#[1278](https://github.com/0xMiden/miden-node/pull/1278)).
 - Added `validator` crate with initial protobuf, gRPC server, and sub-command (#[1293](https://github.com/0xMiden/miden-node/pull/1293)).
 - [BREAKING] Added `AccountTreeWithHistory` and integrate historical queries into `GetAccountProof` ([#1292](https://github.com/0xMiden/miden-node/pull/1292)).
+- [BREAKING] Added `rocksdb` feature to enable rocksdb backends of `LargeSmt` ([#1326](https://github.com/0xMiden/miden-node/pull/1326)).
 - [BREAKING] Handle past/historical `AccountProof` requests ([#1333](https://github.com/0xMiden/miden-node/pull/1333)).
 - Implement `DataStore::get_note_script()` for `NtxDataStore` (#[1332](https://github.com/0xMiden/miden-node/pull/1332)).
 - Started validating notes by their commitment instead of ID before entering the mempool ([#1338](https://github.com/0xMiden/miden-node/pull/1338)).

Cargo.toml

@@ -57,7 +57,8 @@ miden-tx              = { branch = "next", default-features = false, git = "http
 miden-tx-batch-prover = { branch = "next", git = "https://github.com/0xMiden/miden-base.git" }
 
 # Other miden dependencies. These should align with those expected by miden-base.
-miden-air = { features = ["std", "testing"], version = "0.20" }
+miden-air    = { features = ["std", "testing"], version = "0.20" }
+miden-crypto = { default-features = false, version = "0.19" }
 
 # External dependencies
 anyhow            = { version = "1.0" }

bin/node/Dockerfile

@@ -1,8 +1,9 @@
 FROM rust:1.90-slim-bullseye AS builder
 
+# Install build dependencies. RocksDB is compiled from source by librocksdb-sys.
 RUN apt-get update && \
     apt-get -y upgrade && \
-    apt-get install -y llvm clang bindgen pkg-config libssl-dev libsqlite3-dev ca-certificates && \
+    apt-get install -y llvm clang libclang-dev pkg-config libssl-dev libsqlite3-dev ca-certificates && \
     rm -rf /var/lib/apt/lists/*
 
 WORKDIR /app