feat/ci: workflow adjustments to use rocksdb.a precompiled #1629
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| set -euo pipefail | ||
| test -f rocksdb-artifact/librocksdb.a | ||
| test -f rocksdb-artifact/liblz4.a |
|
Collaborator
There was a problem hiding this comment. Do you think this is still worth adding to CI runs? Right now all large jobs here build on top of the
Contributor
Author
There was a problem hiding this comment. I think we'd safe on link-time, but there is complexity penalty adding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| name: rocksdb-static | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| runs-on: | ||
| required: true | ||
| type: string | ||
| checkout-ref: | ||
| required: false | ||
| type: string | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| env: | ||
| # Reduce cache usage by removing debug information. | ||
| CARGO_PROFILE_DEV_DEBUG: 0 | ||
|
|
||
| jobs: | ||
| rocksdb-static: | ||
| name: rocksdb-static | ||
| runs-on: ${{ inputs.runs-on }} | ||
| timeout-minutes: 30 | ||
| env: | ||
| ROCKSDB_RUST_VERSION: "" | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ inputs.checkout-ref || github.ref }} | ||
| - name: Cleanup large tools for build space | ||
| uses: ./.github/actions/cleanup-runner | ||
| - name: Install RocksDB | ||
| uses: ./.github/actions/install-rocksdb | ||
| - name: Rustup | ||
| run: rustup update --no-self-update | ||
| - name: Resolve RocksDB version | ||
| run: | | ||
| set -euo pipefail | ||
| rocksdb_version=$(cargo tree --locked --depth=0 -i librocksdb-sys | tail -n 1 | awk '{print $2}' | sed 's/^v//') | ||
| if [ -z "$rocksdb_version" ]; then | ||
| echo "::error::Unable to determine librocksdb-sys version from cargo tree." | ||
| exit 1 | ||
| fi | ||
| echo "ROCKSDB_RUST_VERSION=$rocksdb_version" >> $GITHUB_ENV | ||
| - name: RocksDB cache date | ||
| id: rocksdb-date | ||
| run: echo "date=$(date +%Y-%m-%d)" >> $GITHUB_OUTPUT | ||
| - name: Cache RocksDB static library | ||
| id: rocksdb-cache | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: rocksdb-artifact | ||
| key: rocksdb-${{ runner.os }}-${{ runner.arch }}-${{ env.ROCKSDB_RUST_VERSION }}-${{ steps.rocksdb-date.outputs.date }}-${{ hashFiles('Cargo.lock') }} | ||
| - name: Build rocksdb.a | ||
| if: steps.rocksdb-cache.outputs.cache-hit != 'true' | ||
| run: | | ||
| set -euo pipefail | ||
| CARGO_TARGET_DIR=rocksdb-target cargo build -p librocksdb-sys@${{ env.ROCKSDB_RUST_VERSION }} --locked | ||
| mkdir -p rocksdb-artifact | ||
| for lib in librocksdb.a liblz4.a; do | ||
| lib_path="$(find rocksdb-target -name "$lib" -print -quit)" | ||
| if [ -z "$lib_path" ]; then | ||
| echo "::error::Missing $lib." | ||
| exit 1 | ||
| fi | ||
| cp "$lib_path" "rocksdb-artifact/$lib" | ||
| done | ||
| - name: Upload RocksDB static library | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: rocksdb-static-${{ runner.arch }} | ||
| path: rocksdb-artifact | ||
| if-no-files-found: error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.