chore(ntx): replace in memory with sqlite database#1662
Merged
Mirko-von-Leipzig merged 20 commits intonextfrom Feb 20, 2026
Merged
chore(ntx): replace in memory with sqlite database#1662Mirko-von-Leipzig merged 20 commits intonextfrom
Mirko-von-Leipzig merged 20 commits intonextfrom
Conversation
Base automatically changed from
santiagopittella-ntx-builder-persistence
to
next
February 11, 2026 06:46
SantiagoPittella
force-pushed
the
santiagopittella-ntx-builder-state-mgmt-migration-v2
branch
4 times, most recently
from
7c7bb45 to
6c02043
Compare
fix: proper state transitions chore: move transactions into Db methods chore: remove dead code chore: add raw SQL queries to docs chore: use source deserialization errors
SantiagoPittella
force-pushed
the
santiagopittella-ntx-builder-state-mgmt-migration-v2
branch
from
2191b25 to
1085eb0
Compare
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Partial review only so far
mmagician
changed the title
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Bit more of a review; the rest will largely depend on that one question I have about db writes.
Mirko-von-Leipzig
approved these changes
Feb 19, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Some small nits; I think there may be some more minor issues but lets get this in and see how it looks once we use it.
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Mirko-von-Leipzig
deleted the
santiagopittella-ntx-builder-state-mgmt-migration-v2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phase 2 of #1628
closes #1656