Skip to content

Conversation

@PhilippGackstatter
Copy link
Contributor

Update usages of account updates and batch and block to use the newly introduced TransactionHeader from 0xMiden/miden-base#1247.

These are relatively minor updates. I think the only thing worth calling out is the insertion of the transactions into the DB. Currently the table has these fields:

CREATE TABLE transactions (
    transaction_id BLOB    NOT NULL,
    account_id     BLOB    NOT NULL,
    block_num      INTEGER NOT NULL,

We could insert more data here from the TransactionHeader, but how exactly depends on some details I'm not familiar with, like should we insert notes into this table and reference them via a foreign key or is that a bad idea because we remove notes from the notes table when they're consumed?.

If we want to support the explorer to get the transactions of a block, then we probably have to insert the full headers?

@PhilippGackstatter PhilippGackstatter changed the title feat: Update to use TransactionHeader Update to use TransactionHeader Apr 1, 2025
Copy link
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. How are these toml changes passing the taplo lint check?

Are the lines too long and it gave up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about that too but I just ran make lint. I guess they're too long and that's what it fell back to.

@Mirko-von-Leipzig Mirko-von-Leipzig added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Apr 2, 2025
@PhilippGackstatter PhilippGackstatter merged commit cd0f726 into next Apr 3, 2025
14 checks passed
@PhilippGackstatter PhilippGackstatter deleted the pgackst-tx-header branch April 3, 2025 21:35
SantiagoPittella pushed a commit that referenced this pull request May 16, 2025
* feat: Update to use `TransactionHeader`

* chore: Add changelog

* chore: make lint

* chore: Remove changelog entry

* chore: Update used miden-base version

* chore: Update to latest miden base

* chore: Use next branch of miden-base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants