-
Notifications
You must be signed in to change notification settings - Fork 92
Update to use TransactionHeader
#781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TransactionHeaderTransactionHeader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. How are these toml changes passing the taplo lint check?
Are the lines too long and it gave up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering about that too but I just ran make lint. I guess they're too long and that's what it fell back to.
* feat: Update to use `TransactionHeader` * chore: Add changelog * chore: make lint * chore: Remove changelog entry * chore: Update used miden-base version * chore: Update to latest miden base * chore: Use next branch of miden-base
Update usages of account updates and batch and block to use the newly introduced
TransactionHeaderfrom 0xMiden/miden-base#1247.These are relatively minor updates. I think the only thing worth calling out is the insertion of the transactions into the DB. Currently the table has these fields:
We could insert more data here from the
TransactionHeader, but how exactly depends on some details I'm not familiar with, like should we insert notes into this table and reference them via a foreign key or is that a bad idea because we remove notes from the notes table when they're consumed?.If we want to support the explorer to get the transactions of a block, then we probably have to insert the full headers?