chore: update miden-crypto (with unified Felt type)#2649
Draft
chore: update miden-crypto (with unified Felt type)#2649
miden-crypto (with unified Felt type)#2649Conversation
5 tasks
greenhat
force-pushed
the
greenhat-unified-felt
branch
from
90655ba to
975be34
Compare
greenhat
force-pushed
the
greenhat-unified-felt
branch
from
975be34 to
3ced18f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tests the updated
miden-cryptowith the unifiedFelttype.See 0xMiden/crypto#771 for more details on why we want this.
The
miden-cryptoPR is 0xMiden/crypto#819. It swaps theGoldilocks as Feltre-export to theFelt(Goldilocks)wrapper.The plan is to release it as a
miden-cryptov0.22.x patch release sinceGoldilocksandFelttypes are 100% API equivalent. After that change thegitversion to the released version.