Skip to content

chore: address batch kernel review comments - #3615

Merged
zeapoz merged 1 commit into
mmagician-claude/batch-kernel-logicfrom
zeapoz/address-barch-kernel-feedback
Aug 17, 2026
Merged

chore: address batch kernel review comments#3615
zeapoz merged 1 commit into
mmagician-claude/batch-kernel-logicfrom
zeapoz/address-barch-kernel-feedback

Conversation

@zeapoz

@zeapoz zeapoz commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Should be merged on top of #2905.

Addresses most review comments left in #2905 (review):

  • Extracted loop body into process_input_entry MASM helper
  • Introduced TransactionCommitments newtype, simplified TransactionId::new to take it
  • Replaced key functions with pub static LazyLock<Word> constants
  • Rewrote ensure_supported doc comment and renamed local variables for clarity
  • Collapsed filter+map into filter_map; refactored authenticated-note check into .filter().find()
  • Added MASM stack traces to assert_all_output_notes_created
  • Removed redundant type annotations on Vec locals

@zeapoz
zeapoz requested a review from mmagician August 17, 2026 12:11
@zeapoz zeapoz added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Aug 17, 2026

@mmagician mmagician left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks! ✅

Comment thread crates/miden-protocol/asm/kernels/batch/lib/epilogue.masm
Comment thread crates/miden-protocol/src/batch/kernel.rs
Comment thread crates/miden-protocol/src/batch/kernel.rs
Comment thread crates/miden-protocol/src/transaction/transaction_id.rs Outdated
@zeapoz
zeapoz force-pushed the zeapoz/address-barch-kernel-feedback branch from 171e578 to 3ff3d6d Compare August 17, 2026 12:54
@zeapoz
zeapoz merged commit d7973e8 into mmagician-claude/batch-kernel-logic Aug 17, 2026
16 checks passed
@zeapoz
zeapoz deleted the zeapoz/address-barch-kernel-feedback branch August 17, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants