Skip to content

refactor(protocol): read only native account state in validate_new_account - #3657

Merged
mmagician merged 3 commits into
mmagician-claude/fix-l12-reserved-elements-validationfrom
mmagician-claude/native-accessors-validate-new-account
Aug 21, 2026
Merged

refactor(protocol): read only native account state in validate_new_account#3657
mmagician merged 3 commits into
mmagician-claude/fix-l12-reserved-elements-validationfrom
mmagician-claude/native-accessors-validate-new-account

Conversation

@mmagician

@mmagician mmagician commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

validate_new_account read the account ID, nonce and vault root through the active-account accessors, even though it only ever validates the native account. Switches those three reads to the native variants.

This is a follow-up to #3610, which converted the other native-only procedures.

claude added 2 commits August 21, 2026 06:55
…count

validate_new_account read the account ID, nonce and vault root through the
active account, even though it only ever validates the native account. The
native variants of all three already exist, so switch to them and leave the
active accessors for the procedures that genuinely serve foreign accounts.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…into mmagician-claude/native-accessors-validate-new-account
@mmagician mmagician added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Aug 21, 2026
Comment thread crates/miden-protocol/asm/kernels/transaction-core/src/prologue.masm Outdated
@mmagician
mmagician marked this pull request as ready for review August 21, 2026 08:07
@mmagician
mmagician requested review from bobbinth and zeapoz August 21, 2026 08:08
@mmagician mmagician changed the title refactor(protocol): read only native account state in validate_new_account refactor(protocol): read only native account state in validate_new_account Aug 21, 2026

@zeapoz zeapoz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@partylikeits1983 partylikeits1983 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mmagician
mmagician added this pull request to the merge queue Aug 21, 2026
Merged via the queue into next with commit 77d96f5 Aug 21, 2026
19 checks passed
@mmagician
mmagician deleted the mmagician-claude/native-accessors-validate-new-account branch August 21, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants