fix(fees): schedule sponsorship notes at zero - #3702
Merged
Conversation
partylikeits1983
marked this pull request as ready for review
August 24, 2026 11:46
mmagician
reviewed
Aug 24, 2026
Fumuran
approved these changes
Aug 25, 2026
Fumuran
left a comment
Fumuran
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thank you! I agree that the approach which Marti suggested is better, and it avoids code complication as well: the resulting changes are super clear.
mmagician
requested changes
Aug 26, 2026
partylikeits1983
added
the
pr-from-maintainers
…schedule # Conflicts: # crates/miden-tx/src/pricer.rs
mmagician
approved these changes
Aug 27, 2026
mmagician
left a comment
mmagician
left a comment
Collaborator
There was a problem hiding this comment.
I think the original return type was correct, so this needs a tiny refactor, but otherwise looks great! Thanks for addressing the comments ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FEE_SPONSORSHIPin generatedBasicConstantFeePolicyschedules with a zero fee by defaultNetworkNotePricercostsCloses #3580.