Skip to content

refactor(standards): split fee estimation out of pay_fee #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmagician wants to merge 12 commits into from
+1,186 −749
Open

refactor(standards): split fee estimation out of pay_fee #3796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
eb532da
refactor(standards): split fee estimation out of pay_fee
WiktorStarczewski Sep 2, 2026
c6c6164
docs(standards): fix the estimate_fee_for_asset panic list and name t…
claude Sep 3, 2026
faea1e1
refactor(standards): let estimate_fee take the fee asset ID
claude Sep 3, 2026
5e10378
docs(standards): simplify the estimate_fee note coverage doc
claude Sep 3, 2026
4e70a03
docs: drop the MAST-root clause from the fee split changelog entry
claude Sep 3, 2026
62e225f
docs: name both new apply_cycle_margins inputs in the changelog
claude Sep 3, 2026
a7d9c45
Apply batched suggestions from code review
mmagician Sep 3, 2026
faecf22
refactor(standards): price each network note once in the fee flow
claude Sep 3, 2026
3ce575b
test(standards): sponsor two network notes at their own prices
claude Sep 3, 2026
37a0d02
refactor(standards): cache the sponsorship fee asset value word
claude Sep 3, 2026
92e00db
chore(standards): size the sponsorship cycle margins from a measurement
claude Sep 3, 2026
29739e2
test(standards): guard the sponsorship cycle margins
claude Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

### Changes

- [BREAKING] Split `fee::estimate_fee` out of `fee::pay_fee`, pricing the FEE_SPONSORSHIP notes via the new `fees::estimate_network_note_sponsorships` without creating them, `fee::apply_cycle_margins` now also takes the sponsorship-note and output-note counts, and `fee::estimate_fee` and the `fees` sponsorship walks take the address of a price table of one word per output note in the caller's local memory ([#3784](https://github.com/0xMiden/protocol/pull/3784)).
- Added a check that the guardian public key is not one of the approver public keys ([#3764](https://github.com/0xMiden/protocol/pull/3764)).
- [BREAKING] Incremented the MSRV to 1.98.
- [BREAKING] Updated the Miden VM and crypto crate family to v0.30.0 and `midenc-hir-type` to v0.12.0. `LocalTransactionProver::new` now takes `miden_prover::Prover`, `CoreLibrary` exposes one merged package, and `TransactionVerifier::verify` now returns `VerificationOutcome` so callers can handle outstanding precompile work ([#3782](https://github.com/0xMiden/protocol/pull/3782)).
Expand Down
Loading
Loading