Skip to content

fix(standards): report every storage size a standard note accepts - #3810

Open
onurinanc wants to merge 3 commits into
nextfrom
fix-expected-storage-size
Open

fix(standards): report every storage size a standard note accepts#3810
onurinanc wants to merge 3 commits into
nextfrom
fix-expected-storage-size

Conversation

@onurinanc

Copy link
Copy Markdown
Collaborator

Summary

  • Replace StandardNote::expected_num_storage_items with accepts_num_storage_items, which accepts 13 items for a private MINT note and 20 or more for a public one.
  • Narrow the variable config notes to the sizes their actions use: 1 or 3 for OWNER_CONFIG, 2 to 4 for RBAC_CONFIG, 2 or 32 for FAUCET_METADATA_CONFIG.
  • Add MIN_NUM_STORAGE_ITEMS to OwnerConfigNote, RbacConfigNote and FaucetMetadataConfigNote.
  • Pin the MINT storage item counts to the constants in asm/standards/notes/mint/.

Closes #3809.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expected Storage Size for MINT Notes Matches Only One of Four Valid Layouts

1 participant