test: followups & integration tests optimizations - #2531
Merged
Conversation
CI test timings
Base run: |
Collaborator
Author
|
Should we mark this as |
juan518munoz
marked this pull request as ready for review
September 11, 2026 16:03
TomasArrachea
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed remaining comments from #2481:
into_client_builderTest: code simplifications #2481 (comment)test_onchain_notes_flowwith RPO Test: code simplifications #2481 (comment)AccountSetupis now able to take a pre-built Account Test: code simplifications #2481 (comment)Optimization attemps:
Funderno longer waits for its payment to commit before returning the funding note. That wait was moved to aflush()call after the test body, so a funded account can build its own transaction as soon as the node accepts the payment. Each test process now claims one funder wallet for its whole life instead of claiming one per payment.Increased test thread count fromreverted in 244152c3to6, under the assumption that most test time is under provingNew job to meassure test speedup/slowdown: