Skip to content

test: followups & integration tests optimizations - #2531

Merged
igamigo merged 5 commits into
nextfrom
jmunoz-funder-optimizations
Sep 11, 2026
Merged

test: followups & integration tests optimizations#2531
igamigo merged 5 commits into
nextfrom
jmunoz-funder-optimizations

Conversation

@juan518munoz

@juan518munoz juan518munoz commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Addressed remaining comments from #2481:

Optimization attemps:

  • The Funder no longer waits for its payment to commit before returning the funding note. That wait was moved to a flush() call after the test body, so a funded account can build its own transaction as soon as the node accepts the payment. Each test process now claims one funder wallet for its whole life instead of claiming one per payment.
  • Increased test thread count from 3 to 6, under the assumption that most test time is under proving reverted in 244152c

New job to meassure test speedup/slowdown:

  • Added a new job that prints a table on every PR comparing its (tests) CI times against the dest branch

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

CI test timings

Test type next This PR % diff
Unit tests 19m 57s 15m 35s -21.9%
Integration tests 40m 27s 34m 19s -15.2%
AggLayer tests 10m 09s 9m 55s -2.3%
miden-bench smoke tests 5m 51s 5m 31s -5.7%
Total 76m 24s 65m 20s -14.5%

Base run: 5f6869a of 2026-09-10 on next. This run: 244152c.
Job wall-clock time, queue time excluded. The total adds up only the rows that ran on both sides.

@juan518munoz

Copy link
Copy Markdown
Collaborator Author

Should we mark this as no-changelog? Considering it's not user facing

@juan518munoz
juan518munoz marked this pull request as ready for review September 11, 2026 16:03
Comment thread .github/workflows/test.yml Outdated
@igamigo igamigo added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Sep 11, 2026

@igamigo igamigo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igamigo
igamigo merged commit 290fbb4 into next Sep 11, 2026
23 checks passed
@igamigo
igamigo deleted the jmunoz-funder-optimizations branch September 11, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants