Skip to content

Add more_info_url to transaction lookup response #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xNgoo merged 5 commits into from
Apr 1, 2026
Merged

Add more_info_url to transaction lookup response #158

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6c6c39
Add more_info_url to transaction lookup response
Lynndabel Mar 25, 2026
dcd09ed
Merge branch 'main' into lookup
Lynndabel Mar 26, 2026
7a63cd1
Merge remote-tracking branch 'origin/main' into pr-158
0xNgoo Apr 1, 2026
5c1cfe1
fix: restore asset lookup in transaction response
0xNgoo Apr 1, 2026
a0201a8
fix: satisfy lint for transaction lookup response
0xNgoo Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/runtime/http/express-router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,17 +555,25 @@ export class AnchorExpressRouter {
return;
}

sendJson(res, 200, {
const serverConfig = this.config.get('server');
const responseData: any = {
id: transaction.id,
kind: transaction.kind,
status: transaction.status,
amount: transaction.amount,
asset_code: transaction.assetCode,
account: transaction.account,
interactive_url: `${this.config.get('server').interactiveDomain ?? 'http://localhost:3000'}/deposit/${transaction.id}`,
interactive_url: `${serverConfig.interactiveDomain ?? 'http://localhost:3000'}/deposit/${transaction.id}`,
created_at: transaction.createdAt,
updated_at: transaction.updatedAt,
});
};

// Add more_info_url only when interactive domain is configured
if (serverConfig.interactiveDomain) {
responseData.more_info_url = `${serverConfig.interactiveDomain}/deposit/${transaction.id}`;
}
Comment on lines +578 to +596
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and type safety, I suggest a small refactor here:

  • Avoid using any for responseData. Record<string, unknown> is a more type-safe alternative that aligns with the sendJson function's signature.
  • Extract the URL components into constants to avoid repetition and make the code DRY (Don't Repeat Yourself). This makes it easier to update the URL structure in the future.
Suggested change
const serverConfig = this.config.get('server');
const responseData: any = {
id: transaction.id,
kind: transaction.kind,
status: transaction.status,
amount: transaction.amount,
asset_code: transaction.assetCode,
account: transaction.account,
interactive_url: `${this.config.get('server').interactiveDomain ?? 'http://localhost:3000'}/deposit/${transaction.id}`,
interactive_url: `${serverConfig.interactiveDomain ?? 'http://localhost:3000'}/deposit/${transaction.id}`,
created_at: transaction.createdAt,
updated_at: transaction.updatedAt,
});
};
// Add more_info_url only when interactive domain is configured
if (serverConfig.interactiveDomain) {
responseData.more_info_url = `${serverConfig.interactiveDomain}/deposit/${transaction.id}`;
}
const serverConfig = this.config.get('server');
const interactiveDomain = serverConfig.interactiveDomain;
const depositUrlPath = `/deposit/${transaction.id}`;
const responseData: Record<string, unknown> = {
id: transaction.id,
kind: transaction.kind,
status: transaction.status,
amount: transaction.amount,
asset_code: transaction.assetCode,
account: transaction.account,
interactive_url: `${interactiveDomain ?? 'http://localhost:3000'}${depositUrlPath}`,
created_at: transaction.createdAt,
updated_at: transaction.updatedAt,
};
// Add more_info_url only when interactive domain is configured
if (interactiveDomain) {
responseData.more_info_url = `${interactiveDomain}${depositUrlPath}`;
}


sendJson(res, 200, responseData);
return;
}

Expand Down
3 changes: 3 additions & 0 deletions tests/mvp-express.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,9 @@ describe('MVP Express-mounted integration', () => {
expect(response.body.interactive_url).toBe(
`https://anchor.example.com/deposit/${transactionId}`,
);
expect(response.body.more_info_url).toBe(
`https://anchor.example.com/deposit/${transactionId}`,
);
});
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a good test for the happy path. However, the test suite is missing coverage for the case where server.interactiveDomain is not configured. According to the logic, more_info_url should be omitted in that scenario. Please consider adding a new test case to verify this behavior and ensure robustness.


it('8) webhook route stores event and invokes configured callback', async () => {
Expand Down
Loading