feat: export ServerConfigSchema from public validation module — closes #127

[spiffamani]

Summary

Exports ServerConfigSchema from the public validation module, closing #127.

Changes

• src/utils/validation.ts — Added ServerConfigSchema and validateServerConfig
• tests/utils/server-config-schema.test.ts — 18 focused tests

What's exported

• ServerConfigSchema — runtime schema object with validate() per field
• validateServerConfig() — validates partial ServerConfig, returns error strings

Usage

import { ServerConfigSchema, validateServerConfig } from 'anchor-kit';

ServerConfigSchema.port.validate(3000); // true
validateServerConfig({ port: -1 }); // ['port: invalid value']

Test Results

bun test v1.3.11
18 pass | 0 fail | 54 expect() calls

Checklist

• ServerConfigSchema is publicly importable
• Existing validation exports continue to work
• bun test passes
• Narrowly scoped to described behavior
• No new runtime dependencies

[drips-wave]

@spiffamani Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[gemini-code-assist]

Code Review

This pull request introduces a runtime validation schema and utility function for server configurations, along with a comprehensive test suite. The feedback identifies that the schema is currently incomplete relative to the ServerConfig type, missing properties like corsOrigins and requestTimeout. Additionally, there are suggestions to improve the precision of test assertions and to verify the export of all validation utilities from the package index.

[gemini-code-assist]

The ServerConfigSchema is incomplete. It is typed as Record<keyof Required<ServerConfig>, SchemaField>, which requires all properties of ServerConfig to be defined in the schema. However, corsOrigins and requestTimeout from the ServerConfig interface are missing.

This will likely cause a TypeScript compilation error. If not, it's a significant bug because the validation logic will not cover these properties, which could lead to invalid configuration being silently accepted.

Please add the missing properties to the schema with appropriate validation.

export const ServerConfigSchema: Record<keyof Required<ServerConfig>, SchemaField> = {
  host: {
    type: 'string',
    required: false,
    description: 'Server host address. Defaults to 0.0.0.0',
    validate: (value) => typeof value === 'string' && value.length > 0,
  },
  port: {
    type: 'number',
    required: false,
    description: 'Server port number. Defaults to 3000.',
    validate: (value) =>
      typeof value === 'number' &&
      Number.isInteger(value) &&
      value > 0 &&
      value <= 65535,
  },
  debug: {
    type: 'boolean',
    required: false,
    description: 'Enable debug mode for verbose logging. Defaults to false.',
    validate: (value) => typeof value === 'boolean',
  },
  interactiveDomain: {
    type: 'string',
    required: false,
    description: 'Interactive web portal domain/URL for SEP-24 flows.',
    validate: (value) => {
      if (typeof value !== 'string' || value.length === 0) return false;
      try {
        const url = new URL(value);
        return url.protocol === 'http:' || url.protocol === 'https:';
      } catch {
        return false;
      }
    },
  },
  corsOrigins: {
    type: 'string[]',
    required: false,
    description: 'Allowed origins for CORS.',
    validate: (value) =>
      Array.isArray(value) &&
      value.every((item) => typeof item === 'string' && item.length > 0),
  },
  requestTimeout: {
    type: 'number',
    required: false,
    description: 'Request timeout in milliseconds.',
    validate: (value) =>
      typeof value === 'number' && Number.isInteger(value) && value > 0,
  },
};

[gemini-code-assist]

The assertion expect(errors.length).toBeGreaterThanOrEqual(2) is not very precise. For a more robust test that prevents future regressions, it's better to assert the exact length and content of the errors array.

    expect(errors).toHaveLength(2);
    expect(errors).toContain('port: invalid value');
    expect(errors).toContain('debug: invalid value');

[gemini-code-assist]

This test is incomplete. It only checks for ServerConfigSchema being exported from the utils index. Since validateServerConfig is also exported and intended for public use, the test should verify that it's also accessible from the index file.

    expect(mod.ServerConfigSchema).toBeDefined();
    expect(mod.validateServerConfig).toBeDefined();