fix: throw clear error when buildPaymentXdr() issuer is missing#191
Open
shoaib050326 wants to merge 2 commits into0xNgoo:mainfrom
Open
fix: throw clear error when buildPaymentXdr() issuer is missing#191shoaib050326 wants to merge 2 commits into0xNgoo:mainfrom
shoaib050326 wants to merge 2 commits into0xNgoo:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a validation check to ensure an issuer is provided for non-native Stellar asset payments and adds a corresponding unit test. The reviewer suggested further improving this by validating that the issuer is a valid Stellar public key using a code suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an explicit guard in
StellarUtils.buildPaymentXdr()so non-native asset payments fail with a clear error whenissueris missing.Changes
XLMpayments withoutissuerXLMpayments unchangedRoot cause
buildPaymentXdr()passedissuerdirectly to the lower-level Stellar SDK for non-native assets. Whenissuerwas omitted, the SDK threwIssuer cannot be null, which was less clear and less deterministic than an explicit Anchor Kit guard.Testing
bun test tests/utils/stellar.test.tsbun testImpact
Contributors and SDK consumers now get a clear, immediate error when constructing non-native asset payments incorrectly, while native XLM behavior remains unchanged.
Closes #134