fix: add isPendingTransactionStatus helper#194
Open
shoaib050326 wants to merge 2 commits into0xNgoo:mainfrom
Open
fix: add isPendingTransactionStatus helper#194shoaib050326 wants to merge 2 commits into0xNgoo:mainfrom
shoaib050326 wants to merge 2 commits into0xNgoo:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a utility function isPendingTransactionStatus and a set of pending transaction statuses, supported by new unit tests. The review feedback recommends enhancing the implementation by defining a PendingTransactionStatus type and utilizing it as a TypeScript type guard to facilitate type narrowing in downstream logic.
Contributor
Author
|
Resolved medium Priority Issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a public
isPendingTransactionStatus(status: TransactionStatus): booleanhelper for SEP-24 transaction statuses.The helper is exported from the public types surface and documents the exact statuses it treats as pending or in-progress:
pending_anchorpending_user_transfer_startpending_user_transfer_completepending_externalpending_trustpending_userpending_stellarHow to test?
bun install --frozen-lockfile bun run lint bun testChecklist
bun run testandbun run lintlocally.Issue Reference
Closes #132