feat: add isTerminalTransactionStatus helper#195
Open
shoaib050326 wants to merge 3 commits into0xNgoo:mainfrom
Open
feat: add isTerminalTransactionStatus helper#195shoaib050326 wants to merge 3 commits into0xNgoo:mainfrom
shoaib050326 wants to merge 3 commits into0xNgoo:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the isTerminalTransactionStatus helper function and a list of terminal transaction statuses, supported by new unit tests. Feedback suggests enhancing type safety by defining a TerminalTransactionStatus union type and implementing the helper as a TypeScript Type Guard. Additionally, it is recommended to refactor the tests to iterate over the TRANSACTION_STATUSES array rather than using hardcoded lists to ensure long-term maintainability and prevent desynchronization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a public
isTerminalTransactionStatus(status: TransactionStatus): booleanhelper, documents the set of terminal transaction statuses in the helper JSDoc, and exports the helper through the public types barrel.How to test?
Run:
Checklist
bun run testandbun run lintlocally.Issue Reference
Closes #131