fix: validate payment XDR account addresses#196
Open
shoaib050326 wants to merge 2 commits into0xNgoo:mainfrom
Open
fix: validate payment XDR account addresses#196shoaib050326 wants to merge 2 commits into0xNgoo:mainfrom
shoaib050326 wants to merge 2 commits into0xNgoo:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces upfront validation for Stellar source and destination addresses in the buildPaymentXdr function, adding support for muxed accounts and corresponding unit tests. Review feedback suggests extending this validation to the issuer field for non-native assets and simplifying the sourceAccount instantiation by using MuxedAccount.fromAddress directly, as it handles both standard and muxed addresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds upfront validation for payment XDR account addresses in
StellarUtils.buildPaymentXdr(), so invalid source and destination inputs fail early with clear errors while still accepting valid muxed (M...) addresses supported by the Stellar SDK.How to test?
bun test tests/utils/stellar.test.tsbun testbun run lintYou can also verify manually that:
sourcerejects withsource must be a valid Stellar public or muxed public keydestinationrejects withdestination must be a valid Stellar public or muxed public keyChecklist
bun run testandbun run lintlocally.Issue Reference
Closes #135