fix: StreamingPromptHook panic when chat_history is empty #1132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.with_hook()on streaming prompts without prior chat historypromptProblem
The streaming implementation's
on_completion_callhook was incorrectly trying to get the prompt fromchat_history.last()instead of using thecurrent_promptvariable. This caused:.with_hook()without prior chat history (empty vec)Root Cause
The streaming architecture keeps
current_promptseparate fromchat_historyuntil after the completion (line 267). But the hook code was trying to extract the prompt fromchat_history.last(), which doesn't contain the current prompt at that point.Fix
Use
current_promptdirectly in the hook call, and pass the fullchat_history(which correctly represents prior conversation only):Test plan
cargo check -p rig-corepassescargo test -p rig-core --libpasses (172 tests)Fixes #1131