Skip to content

Conversation

@deepdring
Copy link

@deepdring deepdring commented Aug 21, 2025

Description

fix inconsistent function name in comment

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@deepdring deepdring changed the title chore: fix some inconsistent function name in comment chore: fix inconsistent function name in comment Aug 21, 2025
@sonarqubecloud
Copy link

@deepdring
Copy link
Author

@kamuikatsurgi @lucca30 Hi, Cloud you help to review this pr?

@deepdring
Copy link
Author

@kamuikatsurgi Thank you for your approval!

@deepdring
Copy link
Author

@kamuikatsurgi If there's anything need I to do, please feel free to let me know.

@kamuikatsurgi
Copy link
Member

@kamuikatsurgi If there's anything need I to do, please feel free to let me know.

I'll get this PR approved from another team member and then we'll merge this one. Thanks!

@github-actions
Copy link

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 17, 2025
@github-actions
Copy link

This PR was closed because it has been stalled for 35 days with no activity.

@github-actions github-actions bot closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants