Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggLayer settlement option #79

Open
wants to merge 3 commits into
base: release/v0.0.3
Choose a base branch
from

Conversation

arnaubennassar
Copy link
Collaborator

No description provided.

},
"SettlementBackend": {
"type": "string",
"description": "SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Beethoven service.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT?

Suggested change
"description": "SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Beethoven service.",
"description": "SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Agglayer service.",

@@ -85,4 +96,19 @@ type Config struct {
// gas offset: 100
// final gas: 1100
GasOffset uint64 `mapstructure:"GasOffset"`

// SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Beethoven service.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Beethoven service.
// SettlementBackend configuration defines how a final ZKP should be settled. Directly to L1 or over the Agglayer service.

waitCtx, cancelFunc := context.WithDeadline(ctx, time.Now().Add(a.cfg.AggLayerTxTimeout.Duration))
defer cancelFunc()
if err := a.AggLayerClient.WaitTxToBeMined(txHash, waitCtx); err != nil {
log.Errorf("interop didn't mine the tx: %v", err)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.Errorf("interop didn't mine the tx: %v", err)
log.Errorf("agglayer didn't mine the tx: %v", err)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants