Skip to content

feat: align native bridges with SDK 0.3.0 - #95

Merged
taylanpince merged 5 commits into
masterfrom
align-native-sdks-0.3.0
Sep 18, 2026
Merged

taylanpince merged 5 commits into
masterfrom
align-native-sdks-0.3.0

Conversation

@tolgahan-arikan

@tolgahan-arikan tolgahan-arikan commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Prepare the React Native SDK for version 0.3.0 by aligning its TypeScript API and native bridges with the released Swift and Kotlin SDK 0.3.0 packages.

Changes

  • Add wallet import APIs, wallet key origin, and typed wallet-import attestation failures.
  • Add Solana wallet creation/import, message signing and verification, transfers, and indexer balances.
  • Add typed direct and remote access grants, remote credential inspection, smart-session authorization and usage lookup, and session-specific revocation.
  • Support indexed fee-option selections, including sponsored-transaction selector behavior.
  • Pin the Swift and Kotlin SDK dependencies to 0.3.0 and use Kotlin 2.4.10.
  • Align the bare examples on React Native CLI 20.2.0 so iOS runs through the current Xcode DeviceHub flow.
  • Update the generated API reference, README, 0.2.0-to-0.3.0 migration guide, tests, package-content validation, and minor changeset.

Verification

  • yarn install --immutable
  • yarn verify (35 tests; generated API current at 149 public API IDs)
  • yarn codegen-drift-check
  • yarn check:package (108-file package dry-run, including API.md and MIGRATION.md)
  • Changeset resolves @polygonlabs/oms-wallet-react-native from 0.2.0 to 0.3.0
  • Main Android example builds, installs, and launches with the normal React Native CLI command
  • Main iOS example builds, installs, and launches with the normal signed React Native CLI command
  • Native dependencies resolve to the released Swift and Kotlin SDK 0.3.0 artifacts
  • Expo package installation, typecheck, prebuild, and autolinking verification pass in CI

Release

The included minor changeset will release @polygonlabs/oms-wallet-react-native as 0.3.0 after merge.

@tolgahan-arikan
tolgahan-arikan marked this pull request as ready for review September 17, 2026 17:42
@claude

claude Bot commented Sep 17, 2026

Copy link
Copy Markdown

test

@claude

claude Bot commented Sep 17, 2026

Copy link
Copy Markdown

Code review

1 issue found. Checked for bugs and CLAUDE.md compliance.

CLAUDE.md compliance: Surgical Changes violation in src/index.tsx

File: src/index.tsx lines 19-114 (https://github.com/0xPolygon/oms-wallet-react-native-sdk/blob/3d2fe8aee38fe5feac7e8f9d0aef07557665726a/src/index.tsx)

The export type block from types was fully re-alphabetized, moving dozens of pre-existing, unrelated exports to new positions. Examples:

  • CallContractArg/CallContractParams moved from the top of the block down after seven new entries
  • ContractTokenBalance/NativeTokenBalance/TokenBalance were split apart and redistributed
  • A trailing cluster (OidcProviderConfig, OidcAuthMode, SendTransactionParams, etc.) was broken up and scattered alphabetically

These are pre-existing, unrenamed identifiers repositioned purely for alphabetical ordering -- not functionally required by the SDK 0.3.0 alignment.

Rule violated -- AGENTS.md Surgical Changes (https://github.com/0xPolygon/oms-wallet-react-native-sdk/blob/3d2fe8aee38fe5feac7e8f9d0aef07557665726a/AGENTS.md):

Touch only what you must. Clean up only your own mess. Do not improve adjacent code, comments, or formatting. Do not refactor things that are not broken. The test: every changed line should trace directly to the request.

Suggested fix: Keep pre-existing exports in their original order and only insert the new SDK 0.3.0 type exports (e.g., AccessGrant, SolanaBalance, SmartSessionGrant, etc.) at the end of the block or in logical groupings, matching the pre-existing style.


No bugs found. Native bridge parameter ordering, type hydration, discriminated unions, and error handling are all consistent across TypeScript, iOS (Swift/ObjC), and Android (Kotlin) layers.

@taylanpince
taylanpince merged commit 457ba2d into master Sep 18, 2026
14 checks passed
@tolgahan-arikan
tolgahan-arikan deleted the align-native-sdks-0.3.0 branch September 21, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants