feat(claude-code-review): add opt-in approve mode - #56
Merged
Conversation
Ports the approver-verdict flow from polygon-core-plugins PR 46 into the shared apps-claude-code-review.yml workflow so Apps Team repos can adopt it without maintaining an inline copy. New mode input defaults to comment (existing behaviour, unaffected); mode: approve has Claude submit a real pull-request review verdict via the GitHub CLI that counts toward branch-protection required reviews, with stale-approval dismissal and standing changes-requested carry-over. Also skips drafts.
MaximusHaximus
marked this pull request as ready for review
July 30, 2026 15:08
shan8851
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modeinput to the sharedapps-claude-code-review.ymlreusable workflow:comment(default, unchanged behaviour) orapprove.mode: approveports the approver-verdict flow added inpolygon-core-pluginsPR feat(claude-review): inject team standards via isolated two-job fetch #46 — Claude reads the diff and submits an actual pull-request review verdict via the GitHub CLI (approve or request-changes) instead of just posting a comment, including stale-approval dismissal and standing changes-requested carry-over across pushes.draft == false, since a verdict on unfinished work is meaningless (this applies to both modes, but matters most forapprove).apps-claude-code-review-trigger.yml), commented out since the default stayscomment.No behaviour change for any existing consumer —
modedefaults tocomment, which is byte-for-byte the same step as before.Motivation
polygon-core-plugins wired this up directly (its own repo isn't on the shared-workflow convention). Other Apps Team repos consume the shared
apps-claude-code-review.ymlvia a thin trigger file, so per team-standards ("consume shared workflows, don't maintain inline copies"), the approver flow needed to live here instead of being copy-pasted into each repo that wants it.Test plan
python3 -c "import yaml; yaml.safe_load(...)")pnpm exec changeset status --since=origin/main— no workspace package files touched, no changeset neededmode: approveend-to-end against a real PR (polygon-technology-site, once this merges)