feat(claude-autofix): make allowed_bots a caller input defaulting to '*' - #67
Merged
Merged
Conversation
The bot actor allowlist was hard-coded in the review-feedback job
('claude[bot],github-actions[bot],copilot-pull-request-reviewer[bot],
Copilot') and absent from the check_suite job entirely. Both are
defects for any consumer that reviews under a dedicated reviewer App
(the pattern apps-claude-code-review.yml's REVIEWER_APP_* secrets
exist for): claude-code-action validates the workflow-TRIGGERING actor,
so a changes-requested review from polygon-websites-reviewer[bot] was
rejected and the review -> fix -> approve loop never closed. The
check_suite job rejected any failure on a bot-pushed commit, including
this workflow's own [claude-autofix] pushes.
Add an `allowed_bots` input wired into both claude-code-action steps.
Default '*': both jobs already refuse fork PRs, so every bot that can
reach them is an App the org installed, and a human review body is
exactly as injectable as a bot's. Callers that want to spend autofix
credit only on named reviewers pass a comma-separated login list; the
trigger template shows the override.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
donnfelker
marked this pull request as ready for review
September 3, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The autofix reusable workflow hard-coded
allowed_botsin the review-feedback job (claude[bot],github-actions[bot],copilot-pull-request-reviewer[bot],Copilot) and omitted it from the check_suite job entirely.Defect, root-caused in
0xPolygon/polygon-websites: that repo reviews under a dedicated reviewer App (polygon-websites-reviewer[bot], via theREVIEWER_APP_*secretsapps-claude-code-review.ymlsupports so agent-authored PRs can still receive a required approval).claude-code-actionvalidates the workflow-triggering actor, which forpull_request_reviewis the reviewer, so its changes-requested verdicts were rejected and the review → fix → approve loop never closed. The check_suite job, with noallowed_botsat all, rejected any CI failure on a bot-pushed commit, including autofix's own[claude-autofix]pushes.Fix:
allowed_botsbecomes aworkflow_callinput wired into bothclaude-code-actionsteps. Default is'*'(ruled by @donnfelker): both jobs already refuse fork PRs, so every bot that can reach them is an App the org installed, and a human review body is exactly as injectable as a bot's. Callers that want to spend autofix credit only on named reviewers pass a comma-separated login list; the trigger template shows the override.Behaviour change for existing callers: bots not on the old list (Dependabot, CodeQL, security scanners that request changes) now trigger autofix. The attempt cap,
ai-needs-humanlabel, anddenied_pathsbound what a run can do regardless of trigger.Type of change
Checklist:
yaml-lint) andprettier --checkclean;actionlintnot available locallypolygon-websites' newclaude-autofix.ymlcaller to this SHA and exercise a reviewer-bot changes-requested review.Additional context
Found while installing the autofix caller in
polygon-websitesvia theinstall-github-actionsskill. Draft until the real-run proof lands.🤖 Generated with Claude Code