Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple source accounts for payment operations #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikhilsaraf
Copy link

Always add the SourceAccount to the paymentMuts so we can submit a transaction that includes operations from different source accounts (this is different from the multisig use-case outlined in the readme).

Sample Usage:

ms.Start(a.Address, microstellar.Opts().WithSigner(a.Seed).WithSigner(b.Seed))
ms.PayNative(a.Address, receiver1.Address, "1.0")
ms.PayNative(b.Address, receiver2.Address, "1.0")
err := ms.Submit()

Always including the source account in the paymentMuts is safe even if the source account matches the transaction's source account. This should ideally be done for all operations in microstellar, but it would be great if you could include this PR for now.

@0xfe
Copy link
Owner

0xfe commented Jul 27, 2018

Thanks for the change, however it looks like it breaks some tests.

Also, can you please add an additional test to cover this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants