-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
payment select modal #129
Merged
Merged
payment select modal #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamueleA
force-pushed
the
3118-select-payment-options-modal
branch
from
August 26, 2024 20:57
71a3ae3
to
175c0fc
Compare
SamueleA
changed the title
logic for triggering new payment select modal
payment select modal
Sep 4, 2024
taylanpince
reviewed
Sep 5, 2024
SamueleA
force-pushed
the
3118-select-payment-options-modal
branch
from
September 10, 2024 14:26
cfcc337
to
3117369
Compare
SamueleA
force-pushed
the
3118-select-payment-options-modal
branch
from
September 16, 2024 18:10
9cebccb
to
e31a7e5
Compare
corbanbrook
reviewed
Sep 19, 2024
packages/checkout/src/views/PaymentSelection/PayWithCreditCard.tsx
Outdated
Show resolved
Hide resolved
packages/checkout/src/views/PaymentSelection/PayWithCrypto/PayWithMainCurrency.tsx
Outdated
Show resolved
Hide resolved
packages/checkout/src/views/PaymentSelection/PayWithCrypto/SwapAndPay.tsx
Outdated
Show resolved
Hide resolved
tolgahan-arikan
approved these changes
Sep 20, 2024
corbanbrook
approved these changes
Sep 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* logic for triggering new payment select modal * payment seleciton(wip) * added buy with currency flow * send transactions utility function * swap and buy * utility function * sardine checkout (wip) * credit card payment * card height adjustment * disable other buttons when a TX is in progress * adde sales contract-specific hook * renamed tokenId, collectionAddress and price fields * replaced chainId field with more generic chain field * clean up helpers * transfer to wallet * transfer funds modal context * export transfer funds modal * transfer funds modal * fixed add funds modal, trigger modal * new pnpm lock file * return txhash from onsuccess callback * fix peer deps * onClose callbacks * rename erc1155 sales contract setting modal * callback fns * disable mock connector * moved sardine * refactor selectpaymentmodal settings * regenerate lockfile * added variant to Text tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payment Select Modal V0. New UI will be added in another PR.