TryRecoverSessionAsync and GetNativeTokenBalance #264
+90
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying sequence-unity with
|
| Latest commit: |
dd56447
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://57ee460c.sequence-unity.pages.dev |
| Branch Preview URL: | https://recoversessionasync.sequence-unity.pages.dev |
BellringerQuinn
approved these changes
Mar 7, 2025
| @@ -20,41 +21,19 @@ public class BoilerplateController : MonoBehaviour | |||
| [Header("Components")] | |||
| [SerializeField] private GameObject _featureSelection; | |||
|
|
|||
| private IWallet _wallet; | |||
| private SequenceWallet _wallet; | |||
BellringerQuinn
requested changes
Mar 7, 2025
| if (wallet != null) | ||
| return; | ||
|
|
||
| Debug.LogError("Failed to recover session. Please login."); |
There was a problem hiding this comment.
This code will log an error if secure storage (and session recovery) is disabled - that's a bit confusing in my opinion. Maybe you could pass an onFailure action (or similar) to the task that will log the error instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version Increment
Please ensure you have incremented the package version in the package.json as necessary.
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: