handle unhandled errors and enable errcheck#11
Merged
Conversation
LuisPH3
reviewed
Feb 4, 2025
HerbertJordan
previously approved these changes
Feb 4, 2025
Collaborator
There was a problem hiding this comment.
Looks good. Please address @LuisPH3 comments, then it is ready to merge from my side.
facuMH
force-pushed
the
facundo/unhandled-errors
branch
from
e37a6ef to
64dfae3
Compare
LuisPH3
requested changes
Feb 5, 2025
facuMH
force-pushed
the
facundo/unhandled-errors
branch
from
364676f to
f921937
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of https://github.com/Fantom-foundation/sonic-admin/issues/90
It contributes by handling errors that do not need the caution util, nor occur in tests. These could have a real production impact, so they should be thoroughly tested much like Fantom-foundation/Sonic#378
run make test
Norma test
demonet/static.yml
demonet/dynamic.yml
testing coverage https://docs.google.com/spreadsheets/d/1wma9IgKtWAePlPet0XdyoSQPRv5mU9tZspshbcd6jAc/edit?usp=sharing
this PR also enables
errcheckas part ofmake lint