Skip to content

Fix black Layers panel background under stock wxWidgets 3.3 on macOS #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raulizahi wants to merge 1 commit into
base: feature/codex-kicad-10
Choose a base branch
from
Open

Fix black Layers panel background under stock wxWidgets 3.3 on macOS #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pcbnew/widgets/appearance_controls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,9 @@ APPEARANCE_CONTROLS::APPEARANCE_CONTROLS( PCB_BASE_FRAME* aParent, wxWindow* aFo
int screenHeight = wxSystemSettings::GetMetric( wxSYS_SCREEN_Y );
m_iconProvider = new ROW_ICON_PROVIDER( KIUI::c_IndicatorSizeDIP, this );
m_pointSize = wxSystemSettings::GetFont( wxSYS_DEFAULT_GUI_FONT ).GetPointSize();

// An unset panel background resolves to black under stock wxWidgets 3.3 on macOS
m_panelLayers->SetBackgroundColour( wxSystemSettings::GetColour( wxSYS_COLOUR_WINDOW ) );
m_layerPanelColour = m_panelLayers->GetBackgroundColour().ChangeLightness( 110 );
SetBorders( true, false, false, false );

Expand Down Expand Up @@ -1237,6 +1240,8 @@ void APPEARANCE_CONTROLS::OnDarkModeToggle()
// overriding some virtual method or responding to some wxWidgets event so that the parent
// doesn't have to know what it contains. But, that's not where we are, so... :shrug:

// Re-read the system colour; the explicit background set in the ctor would otherwise go stale
m_panelLayers->SetBackgroundColour( wxSystemSettings::GetColour( wxSYS_COLOUR_WINDOW ) );
m_layerPanelColour = m_panelLayers->GetBackgroundColour().ChangeLightness( 110 );

m_windowLayers->SetBackgroundColour( m_layerPanelColour );
Expand Down