Improve Assembly collision simulation responsiveness - #164
Merged
Conversation
10-X-eng
enabled auto-merge
September 3, 2026 23:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #163.
User-visible outcome
collision_mode=offAssembly simulation mode for kinematic playback. Existing callers continue to default to full collision analysis.not_checked; it can never be reported as collision-free.Performance evidence
Production-sized Windows workload: 27 components and 141 solver-output frames.
731f02277ea814d31f3a59777c8e6d4f5ae37d558dd97468df9ff8b510846f48The complete clean portable Windows build was launched, exercised by the owner, and confirmed to fix the reported behavior.
Red/green TDD
The new tests were added first and failed on the absent frame-worker API, collision policy, progress metrics, skipped-analysis contract, and status rendering. After implementation:
Result: 228 passed in 6.85 s.
Additional verification completed during development:
py_compilepassed for every modified runtime and test module.git diff --checkpassed.Clean Windows package verification
Result: complete Rattler native compile, portable-bundle startup/dependency smoke tests, provider subprocess smoke, Codex app-server smoke, geometry worker smoke, McMaster WebView2 smoke, and windowless-provider smoke all passed.
Portable archive SHA-256:
1eec8503bb9ae345aadb4d80c68d68b360960a549dc2d1d13102499ac569a032.Compatibility
Risk and containment
Frame-parallel collision checking increases temporary memory use because safety requires one deep shape/mesh copy per worker. Worker selection is bounded by frame count, 75% of logical CPUs, and the square root of frame count to balance setup cost and throughput. Pair-level parallelism is disabled inside frame workers to avoid nested oversubscription.