perf: reuse projection icons during stable refresh - #174
Closed
10-X-eng wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Closed at the repository owner request; this performance implementation is being discarded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Eliminates measured duplicate icon work during the Tree and Feature Timeline refresh at the end of large publications.
Why
The representative 307-member Assembly trace proved that the final 1.864-second UI stall was dominated by duplicate Tree and Timeline icon generation, not semantic classification or tessellation.
Red / green evidence
Red baseline (
build/run_vibescript_publication_307_native_trace.ps1):Green, same fixture and command against the exact rebuilt Rattler/MSVC DLL:
Focused test:
Result: 12 passed.
Exact native build:
Result: passed with MSVC, followed by the native benchmark above. A red compile caught an incorrect
QIcon/QPixmapargument during simplification; the corrected target rebuilt and linked cleanly before measurement.Risk and non-goals
Risk is limited to icon caching/reuse. Failed SVG loads are not cached. Keys include every input that changes rendered output. This PR deliberately does not claim to solve the remaining 645 ms final projection stall; bounded GUI-thread widget batching is the next measured step.
Compatibility checklist