Fix unit preference changes for open documents - #189
Open
Anteriousis wants to merge 2 commits into
Open
Conversation
Only update the active document when the selected global unit preference changes. Preserve project units when applying unrelated preferences or disabling IgnoreProjectSchema. Expand Qt coverage to seven scenarios. Red: the unchanged-preference and restore-project-units cases failed against the PR implementation before the fix. Green: both test executables pass after the fix. Validation: pixi run cmake --build build/debug --target UnitSettings_Tests_run QuantitySpinBox_Tests_run --parallel 8 (passed) Validation: pixi run ctest --test-dir build/debug -R "^(UnitSettings|QuantitySpinBox)_Tests_run$" --output-on-failure (2/2 passed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit preference change now updates the active document's unit system when project units are not being ignored, while preserving the view-only behavior when "Ignore project unit system" is enabled. A regression test covers changing units with an open document.
Verification
The focused regression test failed against the pre-fix implementation and passes afterward:
Also verified the existing QuantitySpinBox_Tests_run test passes.
Issues
Fixes #182
Before and After Images
No visual changes; screenshots are not applicable.