Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUMP] Update dependency @ember/test-helpers to v4 (admin) #10129

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 16, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@ember/test-helpers ^3.1.0 -> ^4.0.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "every 1 hour every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Sep 16, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: admin/package-lock.json
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: [email protected]
npm error Found: @ember/[email protected]
npm error node_modules/@ember/test-helpers
npm error   dev @ember/test-helpers@"^4.0.0" from the root project
npm error   peerOptional @ember/test-helpers@"*" from [email protected]
npm error   node_modules/ember-cli-mirage
npm error     dev ember-cli-mirage@"^3.0.3" from the root project
npm error     peerOptional ember-cli-mirage@"*" from [email protected]
npm error     node_modules/ember-file-upload
npm error       dev ember-file-upload@"^9.0.0" from the root project
npm error   3 more (ember-lifeline, ember-qunit, ember-simple-auth)
npm error
npm error Could not resolve dependency:
npm error peerOptional @ember/test-helpers@"^3.3.0" from [email protected]
npm error node_modules/ember-data
npm error   dev ember-data@"^5.3.3" from the root project
npm error   peerOptional ember-data@"*" from [email protected]
npm error   node_modules/ember-cli-mirage
npm error     dev ember-cli-mirage@"^3.0.3" from the root project
npm error     1 more (ember-file-upload)
npm error   1 more (ember-cp-validations)
npm error
npm error Conflicting peer dependency: @ember/[email protected]
npm error node_modules/@ember/test-helpers
npm error   peerOptional @ember/test-helpers@"^3.3.0" from [email protected]
npm error   node_modules/ember-data
npm error     dev ember-data@"^5.3.3" from the root project
npm error     peerOptional ember-data@"*" from [email protected]
npm error     node_modules/ember-cli-mirage
npm error       dev ember-cli-mirage@"^3.0.3" from the root project
npm error       1 more (ember-file-upload)
npm error     1 more (ember-cp-validations)
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-09-23T06_53_41_770Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-09-23T06_53_41_770Z-debug-0.log

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Sep 16, 2024
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@renovate renovate bot force-pushed the renovate/admin-ember-test-helpers-4.x branch from 14e52f8 to 6794eb9 Compare September 23, 2024 06:53
@lionelB
Copy link
Member

lionelB commented Sep 24, 2024

il faut aussi mettre à jour @embroider/core pour que ça fonctionne emberjs/ember-test-helpers#1505
Par contre, npm install rale à cause des peer-dep de @ember-data :(

Copy link
Contributor Author

renovate bot commented Sep 26, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@lionelB
Copy link
Member

lionelB commented Sep 26, 2024

J'ai fait un test en overridant les peerDep qui cassaient (@ember/test-helpers dans ember-data et ember-upload-file)
mais ca marche moyen :D

@lionelB
Copy link
Member

lionelB commented Sep 30, 2024

Je ferme la PR, on attendra que ember-data mette à jour ses dépendances pour monter de version

@lionelB lionelB closed this Sep 30, 2024
Copy link
Contributor Author

renovate bot commented Sep 30, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/admin-ember-test-helpers-4.x branch September 30, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants