Skip to content

[TECH] Mutualiser les heading sur PixOrga (Pix-15826)#10863

Merged
pix-service-auto-merge merged 4 commits intodevfrom
pix-idontknow/one-title-to-rule-them-all
Dec 20, 2024
Merged

[TECH] Mutualiser les heading sur PixOrga (Pix-15826)#10863
pix-service-auto-merge merged 4 commits intodevfrom
pix-idontknow/one-title-to-rule-them-all

Conversation

@xav-car
Copy link
Copy Markdown
Contributor

@xav-car xav-car commented Dec 19, 2024

🎄 Problème

Nous avons un besoin de heading pour chaque page. et il n'y a pas de mutualisation

🎁 Proposition

Y remedier

🧦 Remarques

Suppression d'un composant que l'on utilise plus

🎅 Pour tester

Faire un tour des pages pour vérifier que les headings sont correctes

@xav-car xav-car self-assigned this Dec 19, 2024
@xav-car xav-car added Development in progress team-prescription Adopt US - La Team qui mange et parle fort labels Dec 19, 2024
@pix-bot-github
Copy link
Copy Markdown

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@xav-car xav-car changed the title [TECH] Mutualiser les heading sur PixOrga (Pix-CHRISTMAS) [TECH] Mutualiser les heading sur PixOrga (Pix-15826) Dec 19, 2024
@xav-car xav-car force-pushed the pix-idontknow/one-title-to-rule-them-all branch 12 times, most recently from b3f52ac to c1675ff Compare December 20, 2024 13:09
@xav-car xav-car marked this pull request as ready for review December 20, 2024 13:17
@xav-car xav-car added 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally and removed Development in progress labels Dec 20, 2024
Comment thread orga/app/styles/components/ui/page-title.scss Outdated
Comment thread orga/app/styles/components/ui/page-title.scss
@xav-car xav-car force-pushed the pix-idontknow/one-title-to-rule-them-all branch 3 times, most recently from 7ba0d96 to 67d9c1c Compare December 20, 2024 13:57
Comment thread orga/app/components/ui/page-title.gjs Outdated
@xav-car xav-car force-pushed the pix-idontknow/one-title-to-rule-them-all branch from 67d9c1c to 380f1b4 Compare December 20, 2024 14:05
Copy link
Copy Markdown
Member

@lionelB lionelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelque trucs a revoir mais 👍

Comment thread orga/app/components/ui/page-title.gjs Outdated
Comment thread orga/app/components/places/title.gjs Outdated
Comment thread orga/app/components/statistics/index.gjs Outdated
@machestla machestla added Tech Review OK Func Review OK PO validated functionally the PR 🚀 Ready to Merge and removed 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally labels Dec 20, 2024
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-idontknow/one-title-to-rule-them-all branch from 8bb4cf2 to b4aed3c Compare December 20, 2024 15:10
@pix-service-auto-merge pix-service-auto-merge deleted the pix-idontknow/one-title-to-rule-them-all branch December 20, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design Review OK Func Review OK PO validated functionally the PR 🚀 Ready to Merge team-prescription Adopt US - La Team qui mange et parle fort Tech Review OK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants