[TECH] Refacto - méthodes dans OrganizationPlacesLotRepository (PIX-15818) #11012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
alicegoarnisson
changed the title
alicegoarnisson
force-pushed
the
PIX-15818/refacto-places-lots-for-organization-id
branch
15 times, most recently
from
f5ac8cf to
50a4a6d
Compare
alicegoarnisson
added
👀 Func Review Needed
👀 Tech Review Needed
and removed
Development in progress
labels
xav-car
added
Func Review OK
machestla
reviewed
Jan 13, 2025
| */ | ||
|
|
||
| const getOrganizationPlacesLots = async function ({ organizationId, organizationPlacesLotRepository }) { | ||
| return await organizationPlacesLotRepository.findAllNotDeletedByOrganizationId(organizationId); | ||
| if (!organizationId) { |
machestla
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
… few modifiers method
…nById methods are called
pix-service-auto-merge
force-pushed
the
PIX-15818/refacto-places-lots-for-organization-id
branch
from
50a4a6d to
6e1714b
Compare
pix-service-auto-merge
deleted the
PIX-15818/refacto-places-lots-for-organization-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
A l'intérieur de organization-places-lot-repository, on a 4 méthodes qui font sensiblement la même chose, à quelques colonnes et conditions près : récupérer les lots de places pour une organisation donnée (voir findAllByOrganizationId, findAllByOrganizationIds, et des déclinaisons similaires pour récupérer les utilisateurs non supprimés et ajouter un order by).
🎁 Proposition
🧦 Remarques
🎅 Pour tester