[BUGFIX] Pose d'un verrou pour limiter la création de challenge en certification (PIX-16165) #11193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
alexandrecoin
force-pushed
the
PIX-16165-concurrency-on-next-challenge
branch
from
09b48e7 to
7e72197
Compare
AndreiaPena
force-pushed
the
PIX-16165-concurrency-on-next-challenge
branch
from
7e72197 to
4fad05a
Compare
alexandrecoin
force-pushed
the
PIX-16165-concurrency-on-next-challenge
branch
3 times, most recently
from
0fc6e51 to
4f708ae
Compare
Steph0
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Test technique en local en faisant
- Deux containers (deux port different)
- Un container en debugger apres le lock
- Premier requete => arret sur debugger
- Seconde requete => hang car peut pas prendre le lock
- Relache du point d'arret => requete 1 se termine
- On observe (une millisecond apres) immediatement que la requete 2 se debloque
Du coup pour moi l'objectif de la PR est OK ✅ ! Impossible de faire sur un meme assessmentId deux selections de challenge en meme temps
alexandrecoin
force-pushed
the
PIX-16165-concurrency-on-next-challenge
branch
2 times, most recently
from
815f744 to
e67c05f
Compare
alexandrecoin
added
👀 Tech Review Needed
👀 Func Review Needed
alexandrecoin
force-pushed
the
PIX-16165-concurrency-on-next-challenge
branch
from
e67c05f to
cd0b44d
Compare
alexandrecoin
approved these changes
Jan 24, 2025
AndreiaPena
reviewed
Jan 24, 2025
AndreiaPena
reviewed
Jan 24, 2025
...rtification/evaluation/integration/infrastructure/repositories/assessment-repository_test.js
Outdated
Show resolved
Hide resolved
AndreiaPena
approved these changes
Jan 24, 2025
alexandrecoin
force-pushed
the
PIX-16165-concurrency-on-next-challenge
branch
from
cd0b44d to
1c81e28
Compare
alexandrecoin
added
Tech Review OK
Func Review OK
In order to do so in the certification context, challenge selection had to be migrated using an api
yaf
force-pushed
the
PIX-16165-concurrency-on-next-challenge
branch
from
1c81e28 to
db31f2b
Compare
pix-service-auto-merge
deleted the
PIX-16165-concurrency-on-next-challenge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Nous avons constaté qu'un certain nombre de certifications se retrouvent avec plus de 32 challenge.
Notre plus grosse piste est un soucis de concurrence au niveau de ce endpoint.
🥓 Proposition
Poser un verrou pour empêcher la création de challenge supplémentaire.
🧃 Remarques
Il y a aussi quelque chose a regarder cote Pix App, qui envoi en quelques millisecondes plusieurs appels sur ce endpoint.
😋 Pour tester
Pix certif, creer une session de certif et faire rentrer un candidat
Verifier qu'il peut passer sa certification (proposition de challenges) correctement sans erreur technique
[TECH] Des tests purement techniques seraient interessant pour essayer de verifier la situation de concurrence