Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display autosuggest results on focus back, return to input on key up if first item. #4064

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

oscarssanchezz
Copy link
Contributor

@oscarssanchezz oscarssanchezz commented Jan 23, 2025

Description of the Change

Closes #1860, #3482

How to test the Change

Up arrow on first Autosuggest item

1.- Type something into the autosuggest
2.- Press down to move to the first item.
3.- Press up.
4.- First item should be unselected.

outoffirstitem.mov

Autosuggest list should appear on focus back

1.- Type something into autosuggest
2.- Move the focus away by clicking outside the search input
3.- Click back into the input
4.- Autosuggest list should be displayed.

focusautosuggest.mov

Changelog Entry

Added - Ability to display results on focus back + cached autosuggest results on same query.
Fixed - Bug fix: Cannot get outside of autosuggest list pressing up on first item.

Credits

Props @oscarssanchezz , @JakePT, @felipeelia

Checklist:

@oscarssanchezz oscarssanchezz changed the title WIP: Display autosuggest results on focus back Display autosuggest results on focus back, return to input on key up if first item. Jan 24, 2025
@oscarssanchezz oscarssanchezz added this to the 5.2.0 milestone Jan 25, 2025
@felipeelia felipeelia linked an issue Jan 30, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I need some modification in elastic-press autosuggestion search. Accessibility issues with Autosuggest
2 participants