Display autosuggest results on focus back, return to input on key up if first item. #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarssanchezz
changed the title
1 task
felipeelia
reviewed
Feb 26, 2025
Comment on lines
59
to
68
| cy.get('.wp-block-search__button').focus(); | ||
| cy.get('.wp-block-search__input').click(); | ||
| cy.get('.wp-block-search__input').focus(); | ||
|
|
||
| cy.get('.ep-autosuggest').should(($autosuggestList) => { | ||
| // eslint-disable-next-line no-unused-expressions | ||
| expect($autosuggestList).to.be.visible; | ||
| expect($autosuggestList[0].innerText).to.contains('Markup: HTML Tags and Formatting'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
As e2e tests are very resource intensive, we don't make them as atomic as unit tests. Let's add this last part to the existent test and stick with just one (bigger) test.
There was a problem hiding this comment.
Merged into
single: 3ea6778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #1860, #3482
How to test the Change
Up arrow on first Autosuggest item
1.- Type something into the autosuggest
2.- Press down to move to the first item.
3.- Press up.
4.- First item should be unselected.
outoffirstitem.mov
Autosuggest list should appear on focus back
1.- Type something into autosuggest
2.- Move the focus away by clicking outside the search input
3.- Click back into the input
4.- Autosuggest list should be displayed.
focusautosuggest.mov
Changelog Entry
Credits
Props @oscarssanchezz , @JakePT, @felipeelia
Checklist: