-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #839
base: develop
Are you sure you want to change the base?
Fix typos #839
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
[files] | ||
extend-exclude = [ | ||
".git/", | ||
"tests/test-plugin/text-to-speech-voices.json" | ||
] | ||
ignore-hidden = false | ||
|
||
[default] | ||
extend-ignore-re = [ | ||
"\\bTung Du\\b", | ||
] | ||
|
||
[default.extend-words] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are parts of variable names. |
||
# Typos | ||
"weather" = "whether" | ||
|
||
[default.extend-identifiers] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Complete variable names. |
||
# Typos | ||
"Github" = "GitHub" | ||
"Wordpress" = "WordPress" | ||
"Woocommerce" = "WooCommerce" | ||
"get_post_stati" = "get_post_stati" | ||
"Automattic" = "Automattic" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This means: DO NOT CORRECT |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -458,7 +458,7 @@ public function render_meta_box( \WP_Post $post ) { | |
</label> | ||
</p> | ||
|
||
<div class="classifai-clasify-post-wrapper" style="display: none;"> | ||
<div class="classifai-classify-post-wrapper" style="display: none;"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While this is a typo, because this is used as a class name, we'll need to decide if we want to leave this as-is, as others may be relying on this class for styling purposes and updating this will break things for them. Not overly concerned but something for us to consider There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just adding additional details here that this is used in the classic editor only. |
||
<a href="<?php echo esc_url( wp_nonce_url( admin_url( 'admin-post.php?action=classifai_classify_post&post_id=' . $post->ID ), 'classifai_classify_post_action', 'classifai_classify_post_nonce' ) ); ?>" class="button button-classify-post"> | ||
<?php esc_html_e( 'Suggest terms & tags', 'classifai' ); ?> | ||
</a> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -177,7 +177,7 @@ import './previewer.scss'; | |
* Filters response data depending on the threshold value. | ||
* | ||
* @param {Object} data Response data from NLU. | ||
* @param {Object} thresholds Object containing threshold values for various taxnomy types. | ||
* @param {Object} thresholds Object containing threshold values for various taxonomy types. | ||
* @return {Array} Sorted data. | ||
*/ | ||
function filterByScoreOrRelevance( data = {}, thresholds ) { | ||
|
@@ -513,7 +513,7 @@ document.addEventListener( 'DOMContentLoaded', function () { | |
if ( classifaiNLUCheckbox ) { | ||
classifaiNLUCheckbox.addEventListener( 'change', function () { | ||
const classifyButton = document.querySelector( | ||
'.classifai-clasify-post-wrapper' | ||
'.classifai-classify-post-wrapper' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we decide we don't want to change this class name (mentioned in another comment) we'll want to revert this change as well |
||
); | ||
if ( this.checked === true ) { | ||
classifyButton.style.display = 'none'; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -158,7 +158,7 @@ const TaxonomyControls = ( { onChange, query } ) => { | |
// Append newTerm to taxoInfo.terms. | ||
const terms = { | ||
...taxoInfo.terms, | ||
entitites: [ | ||
entities: [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems like this typo may have caused problems but would be curious to know if that was the case There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. BTW There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dkotter, I just checked this. Due to a typo, the |
||
...taxoInfo.terms.entities, | ||
newTerm, | ||
], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not
variable_names
go here.