-
-
Notifications
You must be signed in to change notification settings - Fork 584
Fix mixed-case custom extension matching #4290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
puneetdixit200
wants to merge
1
commit into
11ty:main
Choose a base branch
from
puneetdixit200:fix-custom-extension-case-insensitive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+64
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1622,6 +1622,26 @@ test("permalink on custom template lang, issue #3619", async (t) => { | |
| }`); | ||
| }); | ||
|
|
||
| test("Mixed-case custom template extensions are discovered, issue #4224", async (t) => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, okay, so the content is less of importance. Gotcha. |
||
| let elev = new Eleventy("./test/stubs-4224/", undefined, { | ||
| config: function(eleventyConfig) { | ||
| eleventyConfig.addTemplateFormats("vZome"); | ||
| eleventyConfig.addExtension("vZome", { | ||
| compile: function(str) { | ||
| return function() { | ||
| return `Rendered ${str.trim()}`; | ||
| }; | ||
| }, | ||
| }); | ||
| }, | ||
| }); | ||
| elev.disableLogger(); | ||
|
|
||
| let results = await elev.toJSON(); | ||
| t.is(results.length, 1); | ||
| t.is(results[0].content, "Rendered mixed-case custom extension"); | ||
| }); | ||
|
|
||
| test("Template data throws error when tags is not an Array or String #1791", async (t) => { | ||
| let elev = new Eleventy("./test/noop/", "./test/noop/_site", { | ||
| config: function (eleventyConfig) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| mixed-case custom extension | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the purpose of this file? |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking: it's an anti-pattern to modify function arguments.
Can you use a new variable like the normalizedPath below?